-
Notifications
You must be signed in to change notification settings - Fork 2.8k
inference-extension: Add PULL_BASE_SHA to the env list #34755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The release pipeline in the inference extension can use PULL_BASE_SHA to get the git commit SHA.
|
Welcome @JeffLuoo! |
|
cc: @ahg-g |
|
Hi @JeffLuoo. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test what is the context for this PR? |
|
I want to add an info metrics that records the version and latest git hash of the build in inference-extension. I have a change kubernetes-sigs/gateway-api-inference-extension@69af61e to use |
|
/approve Thanks |
|
/assign mpherman2 |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahg-g, dims, JeffLuoo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@JeffLuoo: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
The release pipeline in the inference extension can use PULL_BASE_SHA to get the git commit SHA.