Skip to content

Conversation

@JeffLuoo
Copy link
Contributor

The release pipeline in the inference extension can use PULL_BASE_SHA to get the git commit SHA.

The release pipeline in the inference extension can use PULL_BASE_SHA to
get the git commit SHA.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 30, 2025
@k8s-ci-robot k8s-ci-robot requested review from dims and thockin April 30, 2025 19:57
@k8s-ci-robot
Copy link
Contributor

Welcome @JeffLuoo!

It looks like this is your first PR to kubernetes/test-infra 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/test-infra has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@JeffLuoo
Copy link
Contributor Author

cc: @ahg-g

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 30, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @JeffLuoo. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Apr 30, 2025
@ahg-g
Copy link
Member

ahg-g commented Apr 30, 2025

/ok-to-test

what is the context for this PR?

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 30, 2025
@JeffLuoo
Copy link
Contributor Author

I want to add an info metrics that records the version and latest git hash of the build in inference-extension.

I have a change kubernetes-sigs/gateway-api-inference-extension@69af61e to use ${COMMIT_SHA} from the https://cloud.google.com/build/docs/deploying-builds/deploy-cloud-run#continuous_deployment. But from the latest image after the build, the SHA is empty which means that the COMMIT_SHA is not populated. I later found https://docs.prow.k8s.io/docs/jobs/ which has the flag PULL_BASE_SHA that contains the latest SHA to the build. Hence I want to switch to use the PULL_BASE_SHA to get that information.

@ahg-g
Copy link
Member

ahg-g commented Apr 30, 2025

/approve
/lgtm

Thanks

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 30, 2025
@JeffLuoo
Copy link
Contributor Author

JeffLuoo commented May 1, 2025

/assign mpherman2

@JeffLuoo
Copy link
Contributor Author

JeffLuoo commented May 6, 2025

Also gentle ping for @dims or @thockin if you can review the change.

@dims
Copy link
Member

dims commented May 6, 2025

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, dims, JeffLuoo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 6, 2025
@k8s-ci-robot k8s-ci-robot merged commit 6376f38 into kubernetes:master May 6, 2025
7 checks passed
@k8s-ci-robot
Copy link
Contributor

@JeffLuoo: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key k8s-staging-inference-extension.yaml using file config/jobs/image-pushing/k8s-staging-inference-extension.yaml

In response to this:

The release pipeline in the inference extension can use PULL_BASE_SHA to get the git commit SHA.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants